Skip to content

refactor: split appstore from settings and migrate to Typescript and Vue 3#57290

Open
susnux wants to merge 18 commits intomasterfrom
refactor/split-appstore
Open

refactor: split appstore from settings and migrate to Typescript and Vue 3#57290
susnux wants to merge 18 commits intomasterfrom
refactor/split-appstore

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Dec 30, 2025 •
edited
Loading

Summary

  1. Split the settings app into settings + appstore to separate the means
  2. Adjust router to allow the appstore app to register root URLs (to prevent breaking changes in the URLs)
  3. Migrate appstore frontend to Typescript
  4. Use Vue 3 for the appstore frontend

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Dec 30, 2025
@susnux susnux added enhancement 3. to review Waiting for reviews labels Dec 30, 2025
@susnux susnux mentioned this pull request Dec 30, 2025
Open
32 tasks
@susnux susnux added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 30, 2025
@susnux susnux force-pushed the refactor/split-appstore branch from 3a93b94 to d0810b4 Compare December 30, 2025 20:15
@susnux susnux force-pushed the refactor/split-appstore branch from d0810b4 to 3f922df Compare January 16, 2026 21:09
@susnux susnux force-pushed the refactor/split-appstore branch 3 times, most recently from 4843981 to 3ac9531 Compare February 7, 2026 21:11
@blizzz blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026
@susnux susnux force-pushed the refactor/split-appstore branch 3 times, most recently from 047e3f1 to e9a6556 Compare April 7, 2026 02:06
@susnux susnux force-pushed the refactor/split-appstore branch from e9a6556 to 36a37f5 Compare April 22, 2026 14:40
@susnux susnux force-pushed the refactor/split-appstore branch 5 times, most recently from 62187b7 to c553e4a Compare April 28, 2026 10:34
@susnux susnux added 3. to review Waiting for reviews feature: apps management and removed 2. developing Work in progress labels Apr 28, 2026
@susnux susnux marked this pull request as ready for review April 28, 2026 11:24
@susnux susnux requested review from a team and provokateurin as code owners April 28, 2026 11:24
@susnux susnux force-pushed the refactor/split-appstore branch 2 times, most recently from 51873b5 to 6ef84b4 Compare April 28, 2026 22:34
@skjnldsv
Copy link
Copy Markdown
Member

skjnldsv commented Apr 29, 2026

What a PR! 🙈 🤯

@susnux susnux force-pushed the refactor/split-appstore branch from 6ef84b4 to 58e4d63 Compare April 29, 2026 10:27
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 29, 2026

What a PR! 🙈 🤯

Just rebases to solve conflicts :)

artonge
artonge reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the easy part, but before going deeper, any chance this can be split into:

  • app split
  • vue3 migration
  • further fixes and cleanups

?

Comment thread psalm-strict.xml
Comment on lines +42 to +43
<directory name="lib/private"/>
<directory name="lib/public"/>
Copy link
Copy Markdown
Collaborator

@artonge artonge Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get those changes

@susnux susnux force-pushed the refactor/split-appstore branch from 58e4d63 to 1b9bb44 Compare April 29, 2026 16:57
susnux added 18 commits April 29, 2026 19:06
@susnux
refactor: split appstore from settings app
f9ce9de 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): split controllers and use proper root
e9e129c 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: apply strict rector rules on appstore
bad7b9a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
perf(appstore): only send what is needed in app listing
11177c4 
reduces transfered data from 6MiB to <1MiB

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): prepare Vue 3 migration
eb1276a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): migrate markdown component to Typescript
90264b7 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): migrate daemon selection dialog to Typescript and…
b25e00a 
… Vue 3

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): migrate app discover section to Vue 3
371d3dc 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): migrate app management views to Vue 3 and Typescript
829b227 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): migrated app management views to Vue 3
50bcfb5 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): migrate app bundles view to Vue 3
b18b8d2 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): migrate app level badge to css modules
d652759 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): migrate sidebar to Vue 3 and Typescript
6f3eb89 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): migrate appstore views to Vue 3 and Typescript
76f4e97 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(appstore): handle in-app-search of appstore
3b6ccaf 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test(appstore): adjust cypress tests for app split
7e1be39 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
build: harden module name generation
abd8e5f 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: compile assets
0134a08 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the refactor/split-appstore branch from 1b9bb44 to 0134a08 Compare April 29, 2026 17:12
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 29, 2026 •
edited
Loading

I reviewed the easy part, but before going deeper, any chance this can be split

You mean separate PRs? I am not sure because after the split you need to adjust the code to work again.
So its a bit mangled with the migration things, but if its easier I can try to separate it into different PRs.

I will at least separate abd8e5f ℹ️ done here #59996

But I tried to keep commits separated:

This was referenced Apr 29, 2026
Merged
Open
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Apr 29, 2026

Split the PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge left review comments

Copilot code review Copilot Copilot left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@pringelmann pringelmann Awaiting requested review from pringelmann

@miaulalala miaulalala Awaiting requested review from miaulalala

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: apps management

Projects

None yet

Milestone

Nextcloud 34

5 participants

@susnux @skjnldsv @artonge @blizzz